Skip to content

Conversation

@puckowski
Copy link
Contributor

What:

Fix issue #4354 unknown at-rule expressions should not have commas in keyword list.

Why:

Current behavior (4.4.0+):

.box {
  @apply h-64, w-64;
}

Expected behavior:

.box {
  @apply h-64 w-64;
}

There have been downstream issues, see: web-infra-dev/rsbuild#5688

Checklist:

  • Documentation
  • Added/updated unit tests
  • Code complete

Should be a less hacky solution than #4366
Seems some logic was not needed as tests passed without some problematic code.
I added some additional layer at-rule tests since the regression was caused by code ntroduced to support layer at-rules.

* Fix issue less#4354 unknown at-rule expressions should not have commas in
  a keyword list.
* Add some additional layer at-rule tests.
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Nov 22, 2025
@puckowski
Copy link
Contributor Author

@matthew-dean I know we have a major test refactor pending but I hope you can review the general idea of this PR in your spare time since this bug is impactful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant